-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda-python): add local bundling option #26062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
e9f620d
to
6b87157
Compare
EDIT: I got something working - I ran it in us-east-1. I got as far as running
I don't have all those regions bootstrapped either. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@polothy thanks for getting this started! For the python local bundling feature we need to provide the bundling logic rather than expecting the user to provide it. Something like what is done with the lambda-nodejs construct.
I wasn't planning to take this PR that far. We can close it. |
Docker bundling is slow, but sometimes necessary. This just gives the end user the option to bundle locally if they want to, but still have the option to fallback to the Docker bundling.
Related to #18290 - but I'm not sure if it closes it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license